Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error getting class information from Ingress annotations #272

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Fix error getting class information from Ingress annotations #272

merged 1 commit into from
Feb 16, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 14, 2017 •
edited
Loading

fixes #269
fixes #270
fixes #83

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 45.91% when pulling 5c9bf12 on aledbf:refactor-annotation-parsers into 1f70373 on kubernetes:master.

@fanhaozzu
Copy link

waiting it be merged

@gianrubio gianrubio mentioned this pull request Feb 15, 2017
Closed
@fanhaozzu fanhaozzu mentioned this pull request Feb 16, 2017
Closed
@aledbf aledbf merged commit 111f338 into kubernetes:master Feb 16, 2017
@aledbf aledbf deleted the refactor-annotation-parsers branch February 16, 2017 13:32
@aledbf aledbf mentioned this pull request Feb 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Milestone
No milestone
5 participants
@aledbf @k8s-reviewable @coveralls @fanhaozzu @k8s-ci-robot